Remove PCK encryption note for Android. #11072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
added
the
area:engine details
Calinou
reviewed
Jul 1, 2025
Member
There was a problem hiding this comment.
Looks good to me.
However, I'm not sure if we should remove the note entirely right now, given how "important" it is. Maybe we should change it to say "Prior to Godot 4.5, ..." instead, so that users on 4.4 who happen to be reading stable once 4.5 is released will still be aware of this limitation.
We can remove the note entirely once 4.6 is out instead.
Member
Author
|
Not sure if it's important, encryption has extremely limited use, and this note most likely was not and will not be noticed by most users. |
skyace65
approved these changes
Jul 2, 2025
Contributor
skyace65
left a comment
skyace65
left a comment
There was a problem hiding this comment.
I'm in agreement with bruvzg. I think it's fine to add without specifying the version
mhilbrunner
approved these changes
Jul 4, 2025
Member
|
Same, I think this is fine. |
Calinou
approved these changes
Jul 4, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since godotengine/godot#105984 was merged, PCK encryption is supported for APK / AAB exports as well.